Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the crash when trying to load an unsupported image file #1163

Merged
merged 3 commits into from
Jul 28, 2022
Merged

Fix the crash when trying to load an unsupported image file #1163

merged 3 commits into from
Jul 28, 2022

Conversation

markccchiang
Copy link
Contributor

Closes #1161. The backend will cache a file loader as a null pointer if the file format is unsupported. I added a check whether a file loader is a null pointer before checking its updated time.

@confluence confluence self-assigned this Jul 27, 2022
kswang1029
kswang1029 approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@kswang1029 kswang1029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all current e2e tests are passing.

Tried to load various kinds of unsupported files in CARTA and CARTA behave correctly without crashing. 👍

@confluence confluence merged commit 3ec3029 into dev Jul 28, 2022
@confluence confluence deleted the mark/1161_crash_for_unsupported_files branch July 28, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kswang1029 kswang1029 kswang1029 approved these changes

@confluence confluence confluence approved these changes

Assignees

@confluence confluence

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[critical for v3-stable release] backend crash when trying to load an unsupported image file
3 participants
@markccchiang @confluence @kswang1029